warning error with metatag admin_ui

lonalore / metatag

e107 (v2) plugin - This plugin allows you to automatically provide structured metadata, aka "meta tags", about a website.

GNU General Public License v3.0

12 stars 10 forks source link

warning error with metatag admin_ui #16

Closed Jimmi08 closed 5 years ago

Jimmi08 commented 5 years ago

Just report, there were changes in core I think.

Declaration of metatag_admin_ui::beforeUpdate($new_data, $old_data) should be compatible with e_admin_ui::beforeUpdate($new_data, $old_data, $id), Line 218 of G:\php72\htdocs\***\e107_plugins\metatag\admin_config.php

lonalore commented 5 years ago

Nice! I love API changes that has not been communicated to the developers properly. Do you know about any changelog or blog post about this? I think this affects all plugins that uses this method.

lonalore commented 5 years ago

Fortunately this was just my fault. :) I left last param on method.