londonhackspace / hackspace-foundation-sites

London Hackspace web site
https://london.hackspace.org.uk
32 stars 34 forks source link

Stop kiosk from giving out emails #179

Closed girlpunk closed 5 years ago

girlpunk commented 5 years ago

It was noted the other day that the kiosk is displaying a list of other user's email addresses in as autocomplete options in the add card page.

The strange property value is due to chromium's interesting autocomplete handling ( see https://bugs.chromium.org/p/chromium/issues/detail?id=468153#c164 for more details).

Lexicality commented 5 years ago

Since you're disabling autocomplete (previous entries) rather than autofill (purposefully saved entries) you can just use "off" and chrome will respect that.

https://developers.google.com/web/updates/2015/06/checkout-faster-with-autofill

In the past, many developers would add autocomplete="off" to their form fields to prevent the browser from performing any kind of autocomplete functionality. While Chrome will still respect this tag for autocomplete data, it will not respect it for autofill data. So when should you use autocomplete="off"? One example is when you've implemented your own version of autocomplete for search. Another example is any form field where users will input and submit different kinds of information where it would not be useful to have the browser remember what was submitted previously.

JasperWallace commented 5 years ago

Fixed with 482eaeca2fb0fd178f0338fd6db2ea73e4ebec74 using Lexicality's suggeston