search

lonefelidae16 / extra-sounds

**UNOFFICIAL** port of ExtraSounds
https://artifactory.kow08absty.com/ui/native/fabricmc/dev/stashy/extra-sounds/
Creative Commons Zero v1.0 Universal
54 stars 2 forks source link

How to remove mob killing sound effect #12

Open wincowski opened 9 months ago

wincowski commented 9 months ago

Describe your suggestion

Minecraft Java Fabric 1.20.1 Extra Sounds 2.3.1 (lonefelidae16-build.1)

The problem I have is sound-like lighting after I kill a mob, it doesn't matter which mob I killed like a cow or skeleton. I can control this sound from extra sound settings > actions > off. But these settings control items, block interactions, and entity events. Do you know how I can disable only this lighting sound?

Additional context

latest.log

lonefelidae16 commented 9 months ago

Would you like to build this project yourself? The affected mixin you mentioned is action.LivingEntityMixin in extrasounds.mixins.json#12. Remove this line and build it. Also, you can refer to the build instructions on the wiki. Please checkout refs/tags/stable/1.20.1-build.1 instead of refs/heads/dev.

Otherwise, turn off Action sound.

lonefelidae16 commented 9 months ago

Another option: use a resource pack to replace the poof sound with a muted sound source.

tested on 1.20.1: ExtraSounds-muteEntityDeath.zip

I thought I could just rewrite sounds.json and set volume to 0, but Minecraft gives me a warning: IllegalArgumentException: Invalid volume, and it won’t be muted. If I described the value as close to zero as possible, e.g. 0.00001, it’ll be pseudo-muted, but it’s not completely silent. So, if you’re going to use a resource pack, you might as well replace it with a muted sound source.

wincowski commented 9 months ago

Would you like to build this project yourself? The affected mixin you mentioned is action.LivingEntityMixin in extrasounds.mixins.json#12. Remove this line and build it. Also, you can refer to the build instructions on the wiki. Please checkout refs/tags/stable/1.20.1-build.1 instead of refs/heads/dev.

Otherwise, turn off Action sound.

I applied this one, removed the sound line from JSON, and added it to the config file but still, this sound is in the game. I don't want to offend you but this sound is so annoying for me

lonefelidae16 commented 9 months ago

I applied this one, removed the sound line from JSON, and added it to the config file but still, this sound is in the game.

There are two JSON files, sorry for the lack of clarity. Modifying sounds.json in assets directory does not make any sense for revisions prior to 6e40e3e5b7b628a3cd4dfc203cca42bf75e125b1.

If you wish to modify this repo and create a Jar, please edit extrasounds.mixins.json as above, or comment out action.LivingEntityMixin#36.

If you wish to use Minecraft’s resource pack feature, replace the poof sound in assets/extrasounds/sounds/entity/poof.ogg with a silent sound source as shown in the attached zip file. This can be applied to ogg files placed in Jar as well as to packs placed in the resourcepacks directory in your game.

wincowski commented 9 months ago

I applied this one, removed the sound line from JSON, and added it to the config file but still, this sound is in the game.

There are two JSON files, sorry for the lack of clarity. Modifying sounds.json in assets directory does not make any sense for revisions prior to 6e40e3e.

If you wish to modify this repo and create a Jar, please edit extrasounds.mixins.json as above, or comment out action.LivingEntityMixin#36.

If you wish to use Minecraft’s resource pack feature, replace the poof sound in assets/extrasounds/sounds/entity/poof.ogg with a silent sound source as shown in the attached zip file. This can be applied to ogg files placed in Jar as well as to packs placed in the resourcepacks directory in your game.

Thanks for your answers and help but I don't understand this stuff very much I mean it's so confusing for me. If it is easy for you can you share a file and I can try it maybe?

lonefelidae16 commented 9 months ago

Thanks for your answers and help but I don't understand this stuff very much I mean it's so confusing for me. If it is easy for you can you share a file and I can try it maybe?

Sure, but this would be a special opportunity to provide a customized Jar. It’ll tire me out in the future as it needs continual updating to adapt to your suggestion. I’d like to avoid individual correspondence as much as possible.

extrasounds-2.3.1+1.20.1~6bff3e0.jar.zip

Please consider applying this resourcepack to newer versions.