lonefelidae16 / extra-sounds

**UNOFFICIAL** port of ExtraSounds
https://artifactory.kow08absty.com/ui/native/fabricmc/dev/stashy/extra-sounds/
Creative Commons Zero v1.0 Universal
53 stars 2 forks source link

Split actions settings #13

Closed diskree closed 6 months ago

diskree commented 6 months ago

What?

Why?

This gives the player the ability to customize sounds from there individually. For ex, I like the sound of a bow pull, but the "poof" sound of a mob dying annoys me.

Testing Instructions

  1. Launch the game with the mod
  2. Open game sound settings -> Extra sounds settings
  3. Try changing the settings and check the independence between them

Screenshot

image

Changes

Changes have been made to SoundType and Mixers to accommodate the new settings list order as well as the associated code.

Also, it is fully keep to translated into Russian and Korean.

lonefelidae16 commented 6 months ago

Thanks for your PR. Before merging, could you please tell me about the following questions:

This PR was successfully built. If that sound is annoying to you, you can use and redistribute your custom build without asking.

See also #12

diskree commented 6 months ago

Oh, I should have learn the repository better. Yes, I agree, it is not fully done. Ok, I will fix this in the future and open PR again, maybe.. for now I will distribute my version separately