loneknightpy / idba

124 stars 53 forks source link

Does not build using gcc 6 #16

Closed tillea closed 8 years ago

tillea commented 8 years ago

Hi,

as you can read in the Debian bug report https://bugs.debian.org/811644 idba does not build with gcc version 6 which has stronger type checks:

g++ -DHAVE_CONFIG_H -I. -I.. -I../src -I../gtest_src -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -O3 -fopenmp -pthread -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c -o sequence_reader.o test -f '../src/sequence/sequence_reader.cpp' || echo './'../src/sequence/sequence_reader.cpp ../src/sequence/sequence_reader.cpp: In member function 'virtual bool FastaReader::ReadRecord(Sequence&, std::cxx11::string&, std::cxx11::string&)': ../src/sequence/sequence_reader.cpp:50:40: error: cannot convert 'std::istream {aka std::basicistream}' to 'bool' in return return ReadFasta(*is, seq, comment); ^

../src/sequence/sequence_reader.cpp: In member function 'virtual bool FastqReader::ReadRecord(Sequence&, std::cxx11::string&, std::cxx11::string&)': ../src/sequence/sequence_reader.cpp:55:49: error: cannot convert 'std::istream {aka std::basicistream}' to 'bool' in return return ReadFastq(*is, seq, comment, quality); ^

Makefile:441: recipe for target 'sequence_reader.o' failed

Please note that only the first issue is reported and there might be similar ones later in the build sequence.

Kind regards

   Andreas.
tillea commented 8 years ago

Thanks for the quick response, Andreas.

On Fri, Jul 01, 2016 at 03:08:44PM -0700, Yu Peng wrote:

Closed #16 via #19.


You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/loneknightpy/idba/issues/16#event-710999747

http://fam-tille.de