Add dark theme to favicon

lonely-lockley / archinsight

Simplicity in Code, Power in Design

https://archinsight.org

GNU Affero General Public License v3.0

51 stars 5 forks source link

Add dark theme to favicon #51

Closed lonely-lockley closed 9 months ago

lonely-lockley commented 12 months ago

White favicon may be not visible for users using light color schemes. To make it visible in all conditions, several solutions may be considered:

Try @media (prefers-color-scheme: dark) { style property for favicon in SVG format
Place favicon logo into a dark (like github black #171515) circle

Jaishree2310 commented 12 months ago

Can I take this issue? I am new to open source and would like to contribute to this.

nexuspy commented 12 months ago

can you, please assign it to me?

lonely-lockley commented 12 months ago

@Jaishree2310 you were the first to respond. I can give you this issue. It may be challenging to setup and run the project, so feel free to make a working sample with a dummy html and I will explain how to prepare a PR. Ok? You can find a favicon at the path: editor-ui/frontend/favicon.ico

Jaishree2310 commented 12 months ago

@lonely-lockley thank you for assigning me. yes once dummy is ready you can help me with PR.

lonely-lockley commented 12 months ago

You will find an svg version of the logo here: editor-ui/frontend/static/archinsight-logo-no-background.svg

lonely-lockley commented 9 months ago

Implemented this issue while working on #49