Closed jwhitt3r closed 4 months ago
Addresses #79
Hi! Sorry for a long time taken to review changes. I'll have a look as soon as I'll get back from a business trip.
Did you try to run the whole app or just the Translator service?
Yes, the fix is correct.
Can you please replace explicit typechecks with monadic expression like in the rest of Linker class? I mean using el.hasImports()
and a chain of mapOrElse and forEach?
The type check for NamedImport
is an excess, cause getAlias() method never returns null.
I will merge this pr and update code style later
So I believe this might fix the issue. I believe this was down to the named imports not being checked.
I haven't been able to test the solution as I couldn't get the application to run based on the readme