lonetech / nolo-osvr

OSVR plugin for LYRobotix Nolo VR tracker system
Apache License 2.0
12 stars 8 forks source link

Off-By-One Error in Right-Hand Controller Semantic Mapping #11

Closed nanospork closed 6 years ago

nanospork commented 6 years ago

The semantic mapping for the buttons is off-by one. Note that the left-hand controller, for example, is using buttons 0-5, and the right-hand controller is using 7-12. The right-hand controller should be using 6-11. The analog axes appear to be incorrect as well.

I would just submit a PR for this, but I can't get the plugin to build on Windows. I can't even apparently point it to hidapi.h properly? I'm not sure why it's so difficult, because building OSVR-Fusion was easy.

Perhaps a separate issue should be opened regarding building on Windows.

Conzar commented 6 years ago

I forked, and will fix the issue (hopefully).

Conzar commented 6 years ago

Also, here is my branch WIP: https://github.com/Conzar/nolo-osvr/tree/remapping_ids_for_steamvr