Fixes Off-By-One in Json and Adds Windows Build Instructions to Readme

lonetech / nolo-osvr

OSVR plugin for LYRobotix Nolo VR tracker system

Apache License 2.0

12 stars 8 forks source link

Fixes Off-By-One in Json and Adds Windows Build Instructions to Readme #13

Closed nanospork closed 7 years ago

nanospork commented 7 years ago

First and foremost, I apologize for not separating these into two branches.

This PR fixes #11, the off-by-one error in com_osvr_Nolo.json that was causing right-hand controller buttons to register incorrectly (e.g. the "menu" button was seen at the "grip" semantic path.)

It also closes #12 by including (hopefully) extensive instructions in readme.md for building on Windows.

lonetech commented 7 years ago

Apologies for my inactivity. I shall try to inspect and merge soon.

nanospork commented 7 years ago

No worries. Looks like Conzar's PR #14 includes these changes so you can probably just close this one and merge his.