search

lonetwin / pythonrc

lonetwin's pimped-up pythonrc
MIT License
131 stars 15 forks source link

Walrus operator fails on Python 3 < 3.8 #37

Open DNSGeek opened 4 years ago

DNSGeek commented 4 years ago

`tdknox@devvm267:~ $ python3 Python 3.7.5+ (default, Jan 24 2020, 11:19:43) [GCC 7.x 20200121 (Facebook) 8.x] on linux Type "help", "copyright", "credits" or "license" for more information. File "/home/tdknox/pythonrc/pythonrc.py", line 183 matches := self.startswith_filter( ^ SyntaxError: invalid syntax

`

lonetwin commented 4 years ago

Hi @DNSGeek , thanks for trying out pythonrc and taking the time to submit this report but it is a conscious decision to move the main version in the master branch to be python 3.8+ compatible.

Please try out the version in the support/py2.x branch instead. It is functionally the same. If you find issues with that version, I'd appreciate any bugs or pull requests.

Although, I did mention this the intent to support 3.8+ in the README when I updated the project, I am guessing this isn't visible enough. I'll add a check at the top of the pythonrc file with a link to the branch.

wadkar commented 4 years ago

All hail the walrus operator 😆