long-war-2 / lwotc

Port of Long War 2 to XCOM 2's War of the Chosen expansion
342 stars 89 forks source link

Dark events rework #102

Closed ansabalirai closed 5 years ago

ansabalirai commented 5 years ago

Based on my experience, dark events seem to be kind of working, in that I have seen both strategic and tactical ones and I am getting missions to counter them. However, the following issues need to be addressed:

yoshimo commented 5 years ago

What is the problem of the first bullet point?

ansabalirai commented 5 years ago

No problem per se, just want to make sure that the WOTC dark events are classified correctly into tactical (permanent) and strategic (temporary) DEs, For instance. I don't think chosen having no weakness should be permanent.

pledbrook commented 5 years ago

Center Mass is a LW2 dark event using the old configuration. I'm not sure it's as impossible to detect as you think.

pledbrook commented 5 years ago

These are the WOTC dark events (none of which are permanent):

    DarkEvents.AddItem(CreateSignalJammingTemplate());
    DarkEvents.AddItem(CreateTheCollectorsTemplate());
    DarkEvents.AddItem(CreateStilettoRoundsTemplate());
    DarkEvents.AddItem(CreateLightningReflexesTemplate());
    DarkEvents.AddItem(CreateReturnFireTemplate());
    DarkEvents.AddItem(CreateBendingReedTemplate());
    DarkEvents.AddItem(CreateSealedArmorTemplate());
    DarkEvents.AddItem(CreateUndyingLoyaltyTemplate());
    DarkEvents.AddItem(CreateBarrierTemplate());
    DarkEvents.AddItem(CreateHighAlertTemplate());
    DarkEvents.AddItem(CreateDarkTowerTemplate());
    DarkEvents.AddItem(CreateLostWorldTemplate());
    DarkEvents.AddItem(CreateCounterattackEventTemplate());
    DarkEvents.AddItem(CreateCollateralDamageTemplate());
    DarkEvents.AddItem(CreateSpiderAndFlyTemplate());
    DarkEvents.AddItem(CreateLeftBehindTemplate());
    DarkEvents.AddItem(CreateGoneToGroundTemplate());
    DarkEvents.AddItem(CreateMadeWholeTemplate());
    DarkEvents.AddItem(CreateWildHuntTemplate());
    DarkEvents.AddItem(CreateLoyaltyAmongThievesAssassinTemplate());
    DarkEvents.AddItem(CreateLoyaltyAmongThievesHunterTemplate());
    DarkEvents.AddItem(CreateLoyaltyAmongThievesWarlockTemplate());

Which should we remove? High Alert and Undying Loyalty are prime candidates I think.

DerAva commented 5 years ago

Adding some comments to the event list below. Overall, in regards to Dark Events, a few things to consider:

DE List:

All Chosen related DEs can probably stay, but should get removed from the pool when all Chosen are dead (see: https://steamcommunity.com/sharedfiles/filedetails/?id=1126771111 )

jmartinez989 commented 5 years ago

hmm I seem to be in the minority here but I really am not bothered too much but the Undying Loyalty DE. It is a bit annoying to have he enemies reanimate but did not hinder my campaign too much.

Also in the minority about high alert. I honestly don't mind it too much, gives me all the more reason to get lots of Shinobis and encourages better positioning for me. Definitely makes things more interesting. Also means that you will likely be less active in missions for that month.

Also regarding bending reed, it is best to remove it because it does something whirlwind doesn't and that is that it gives the stunlancers a permanent boost to mobility when they melee attack. Bending reed is bugged at the moment and whenever I see the Assassin she always gets her mobility up to almost 60 because of how long it takes to kill her and how many times she will attack with her sword. Other than that yes it is redundant.

pledbrook commented 5 years ago

@DerAva Thanks for listing those with descriptions of what they do. I'll remove the duplicates and minimally effective ones.

I don't have an opinion on most of the rest having never encountered them. I think if a dark event forces you to think more carefully about what missions to take, who to take on them, and how to play them, then we should consider retaining them. It kind of depends on how badly they hurt. The truth is, there isn't much play experience with LWOTC and these dark events.

So for High Alert and Undying Loyalty, how about I reduce the duration? Perhaps by half.

@jmartinez989 Hmmm...I'll have a look at the Bending Reed implementation to see if there's an obvious fix for it. Will also check on the workshop.

pledbrook commented 5 years ago

OK, so I'm disabling Bending Reed, Collateral Damage, Stiletto Rounds, and Signal Jamming. I have also implemented the fix for the Chosen DEs so that they aren't in the pool once all the Chosen are defeated.

Finally, I reduced the duration of High Alert and Undying Loyalty to 12-18 days (from 28). We'll need more playtesting to decide whether the numbers need changing or whether they should be removed entirely. To be honest, I think it's partly about players getting used to them and adjusting their play, and also fixing all the other things that make LWOTC campaigns a roller coaster right now.

Last thing: Bending Reed doesn't look like it's bugged. The way it's implemented implies that it absolutely should increase mobility on every attack. However, there is a configuration variable for it: BENDINGREED_MOBILITY_INCREASE in _XComGameDataSoldierSkills.ini. It's currently set to 1.5 (as in 1.5 times the mobility stat on each attack). That could probably do with being reduced to 1.2 or even 1.1.

pledbrook commented 5 years ago

OK, so Bending Reed is definitely bugged, but will likely be fixed in the community highlander. I'll set the mobility multiplier to 1 for now to disable the mobility increase until the bug is fixed.

pledbrook commented 5 years ago

Bending Reed is fixed in our fork of the community highlander (thanks to @MrNiceUK)

pledbrook commented 5 years ago

Closing as most of the original points have been addressed. Please raise additional issues for any specific changes/bugs.