long-war-2 / lwotc

Port of Long War 2 to XCOM 2's War of the Chosen expansion
343 stars 89 forks source link

Fix intro loading scene for infiltration missions #114

Closed ansabalirai closed 5 years ago

ansabalirai commented 5 years ago

Currently, the mission loading screen with Bradford briefing shows the skyranger interior, but it should technically be in the room with the dog (read: faceless) photo, since the squad is already there for some time and not being deployed currently. Also, in case multiple missions are infiltrating, the skyranger is loaded with a different squad than the one that is to appear on the mission being loaded (usually it is the squad you last did a mission with)

pledbrook commented 5 years ago

See this commit in Strategy Overhaul for implementation of the first bit and also for the mission intro, where we want the soldiers walking in rather than dropping via zip lines into the map (for infiltration and Rendezvous missions).

For the second, see this bit of code.

ansabalirai commented 5 years ago

BTW, have you noticed that for rendezvous missions, it is a quick response mission and the avenger actually flies to the relevant region before the mission starts loading (which is not the case for infiltration missions). So, maybe dropping out of the skyranger for rendezvous is ok. In my head, the justification is that you need skyranger to quickly transport rebels and haven advisor to the meeting site since it is quick response. I am splitting hairs though and keeping same behavior as LW2 is totally ok :)

pledbrook commented 5 years ago

Just as I was adding Rendezvous to that comment, I was actually wondering whether it was a drop in or walk in mission. Will have to check YouTube once again.

pledbrook commented 5 years ago

Rendezvous is a walk-in mission. It is weird that the Avenger goes there, but more importantly, the Skyranger does not. So if the Skyranger doesn't go there, what are they zipping down from?

pledbrook commented 5 years ago

The wrong squad on the Skyranger should be raised as a separate issue.