Spawned mission icons clump together

[pledbrook]

All the missions seem to spawn in a very small circle within a region, leading to annoying overlap. Check both XCGS_LWAlienActivity and the XComGame XCGS_WorldRegion.GetRandomLocationInRegion() method. The latter should ensure that the location isn't close to existing entities, but that seems to be breaking down for some reason.

[pledbrook]

I think the big problems with the logic in XComGameState_WorldRegion for selecting a random location are:

• It compares against the region itself, which pretty much excludes locations around the middle (I suspect)
• The random location generation seems not very random, although this may improve as more time passes between each attempt to generate a random location
• The other missions being spawned aren't added to the history yet, so the new location isn't compared against them

I don't think there's anything we can do about the second one, if there is indeed a problem there. The first could be finagled in X2WOTCCommunityHighlander if people wanted that. I don't know what you get from comparing the random location against the region it's in.

The last issue could perhaps be fixed in X2WOTCCommunityHighlander by comparing locations to Geoscape entities in any pending game state, not just submitted ones.

A "dirty" fix that will potentially allow better distribution is to reduce the minimum desired distance between entities from its current value of 0.02. This should allow more spawns close to the centre of the region.