long-war-2 / lwotc

Port of Long War 2 to XCOM 2's War of the Chosen expansion
345 stars 91 forks source link

Laser Sight weapon attachment wrong symbol #1525

Closed McTrevor79 closed 7 months ago

McTrevor79 commented 2 years ago

I noticed that on the laser scatteray the icon for the scope attachment is used when installing a laser sight. Another user on Reddit confirmed this. On conventional shotgun the correct icon is used for laser sight weapon attachment.

copyrite commented 7 months ago

All laser tier weapons are affected, except vektor and SPARK rifle, which have no icon at all (#688).

copyrite commented 7 months ago

Same goes for the corresponding set of coil tier weapons.

copyrite commented 7 months ago

Problem has been traced to Robojumper's Squad Select, which replaces the attachment category images for some attachments. Working theory is that it does so before LWOTC adds its own for laser and coil tier.

Also affected: Expanded magazines and auto-loaders of the same weapons. And more surprisingly, elite auto-loader icon seems to be the stock one for all weapons.

copyrite commented 7 months ago

Elite auto-loader icon is due to a mistake in RJSS default config, report has been sent.

copyrite commented 7 months ago

Fixed by moving RJSS to run after LWOTC so that the attachments exist at the time when they're modified.