Serial disabling any other action granting perks

long-war-2 / lwotc

Port of Long War 2 to XCOM 2's War of the Chosen expansion

345 stars 92 forks source link

Serial disabling any other action granting perks #1661

Open wdanny69 opened 9 months ago

wdanny69 commented 9 months ago

Issue: When Serial is active, it disables some action granting perks that do not trigger upon kill (tested hit n run and close encounters) and will not grant any actions.

Expected behavior: the expectation should be that serial will refund any actions upon a kill but it should also not disable any other action granting perks should the soldier not score a kill

Reproduction: activate serial and attempt to use any action granting perk while also not scoring a kill

mod list: lwotc.txt

Tedster59 commented 4 months ago

There's a lot of things that are explicitly disabled while under Serial, this was an intentional thing. Not sure if we want to change it. Also because of how PostAbilityCostPaid works, basically the first one that returns "true" short circuits it, so you can get a pile of unexpected interactions depending on how each individual effect is set up.