Arc Wave has +0 crit damage

long-war-2 / lwotc

Port of Long War 2 to XCOM 2's War of the Chosen expansion

345 stars 92 forks source link

Arc Wave has +0 crit damage #1679

Open copyrite opened 9 months ago

copyrite commented 9 months ago

Arc Wave has +0 crit damage, i.e. crits with Arc Wave deal the same amount of damage as normal hits. It's debatable what the correct behaviour should be:

Keep as it is?
Give it crit damage?
Don't upgrade the hit result?
Make it always normal hit?
Visualize crits as normal hits?

Tedster59 commented 9 months ago

I'm down to give it proper crit damage if possible.

RustyDios commented 9 months ago

Is it set at +0 Crit so that other crit damage modifying effects can increase it ... like Amplify ?

Tedster59 commented 9 months ago

I think it's just an artifact of the implementation.

Base game 'X2Effect_ArcWaveMultiDamage' uses a WeaponDamageValue, but only ever sets the Damage part of the struct. LW's version does the same, so net effect is Crit is 0. Easy to change, the question is whether we should.