search

long-war-2 / lwotc

Port of Long War 2 to XCOM 2's War of the Chosen expansion
345 stars 92 forks source link

Death from Above only REFUNDS actions and will also only do it when the soldier's turn ends #1695

Open wdanny69 opened 8 months ago

wdanny69 commented 8 months ago

Issue: DFA will only refund an action meaning it will not work with abilities such as rapid fire where the bonus shots do not technically cost an action and thus will not refund. This will also only trigger if the soldier's turn ends or do not have actions. This matters in cases like Light Em Up which allows you to fire without ending your turn and will not refund the action.

Proposal: Since this ability is similar to abilities like Hit N Run where it simply grants a single action when the condition is met, I feel like it makes sense to have DFA behave the same as well. This will allow the first issue to trigger as any kill will result in the action granted and the second issue to also work as it grants an action without having to check for the other conditions which don't really make sense in terms of how its described.

modlist: lwotc.txt

Tedster59 commented 4 months ago

image

It checks if out of AP, and if the ability had AP beforehand, preventing it from triggering off of free actions. Not sure if there's a better way to get context from the previous stage of abilities without just hardcoding exceptions.