long-war-2 / lwotc

Port of Long War 2 to XCOM 2's War of the Chosen expansion
345 stars 92 forks source link

add min haven count to invasion activity #1731

Closed wdanny69 closed 6 months ago

wdanny69 commented 7 months ago

This adds the min haven count condition to the invasion activity similar to haven retaliations so that there are still some rebels that can be rescued. This should help resolve Invasions with 0 rebels that just ends up in an automatic failure as there was no one to rescue.

Currently just using the haven retaliation count as it made the most sense to keep the two the same.

Also updated the logging for "MinRebel" to make it clear whether the activity can launch in a given region.

copyrite commented 7 months ago

From a fluff perspective, this doesn't seem right to me. The aliens should want to invade the region even when there are 0 rebels. Therefore I'd prefer if this would use a mechanism where the mission fails as soon as it spawns (if there is a way to implement that). I realize this is an easier way out to a somewhat rare situation, though.

wdanny69 commented 7 months ago

flavor wise while i agree that does make more sense,

from a gameplay perspective this is more an unfun mechanic and a very swingy one at that when there is very little counterplay to that. i know this is more covering a bit of an edge case as its not very often to reach a liberation status while also having the haven dead but its better this than to allow them to take it for basically free