search

long-war-2 / lwotc

Port of Long War 2 to XCOM 2's War of the Chosen expansion
345 stars 91 forks source link

Bug - Save Squad in Squad View doesn't Work #513

Open BlackRose39 opened 5 years ago

BlackRose39 commented 5 years ago

When you go to squad management and then squad view with no soldiers, the save squad above, which is greyed out, will initially say "not enough soldiers" (if you hover your mouse on it for some time) However, when I add a soldier, it is still greyed out, this time without the hovering mouse description of why.

This has been an issue since the lw2 days:

https://www.reddit.com/r/Xcom/comments/6hhbc9/long_war_2_cant_save_squad/

https://www.reddit.com/r/XCOM2/comments/6hh71m/cant_save_squad_in_long_war_2/

pledbrook commented 5 years ago

I think this is because there is no mission state associated with the Squad Select screen when used at this point. That's important, because the button is disabled if the mission can't be launched. What mission? Exactly.

UIScreenListener_SquadSelect_LW either needs to enable the button explicitly or set up a dummy mission state that says the mission can be launched.

pledbrook commented 5 years ago

I honestly find that squad management UI confusing in general!

BlackRose39 commented 5 years ago

Just to report another bug related to squad view, tired soldiers do not show up. Wounded soldiers still show up, but not those who are tired. Not sure about those who are "shaken," but likely so.

LW2 probably doesn't have the code at the time to account for these new states introduced in WOTC, so the new values (via code) is missing and needs to be put in for LWOTC.

I honestly find that squad management UI confusing in general!

Well, I'm definitely up about seeing some re-hauling of the entire squad management system/UI to be more functional!