long-war-2 / lwotc

Port of Long War 2 to XCOM 2's War of the Chosen expansion
345 stars 91 forks source link

Shaken soldier recovering to full will almost instantly upon return to Avenger #594

Closed allenhu0912 closed 4 years ago

allenhu0912 commented 5 years ago

save_AUTOSAVE- Campaign 72, Mission 103, Turn 6.zip

pledbrook commented 5 years ago

I think this has to do with borderline Shaken and some of the logic in the base game. Although even so, that's very weird. Will look into it.

pledbrook commented 5 years ago

Can confirm. There's some rounding error in the base game such that the soldier is given a status of Shaken, even though their will is high enough to be just Tired. The transition value is 18.48. A will below that should be Shaken, whereas a will above it should be Tired. The soldier has a will of 19.

idontknow12 commented 5 years ago

I've just encountered this behavior of recovering their full will when the shaken effect wears off and it feels very wrong to me. The soldiers should recover their will slowly in a couple of weeks (as normal will regen goes) and not instantly when the effect ends.

ansabalirai commented 5 years ago

I know WOTC introduced new will mechanics compared to vanilla. but just to point out that in LW2, a shaken soldier (i.e. with zero will) can recover and have their will increases after doing a successful mission and getting a kill, effective immediately. Not sure how we can make it consistent here, but just pointing it out

idontknow12 commented 5 years ago

Yeah but there was some risk there in taking a 0 will soldier on a mission, here you get full will for free. Also, and most importantly, will was not a replenishing bar in long war 2, It was a stat like aim that was always full. It can't be compared to the new will mechanic in wotc or lwotc, which indicates fatigue.

pledbrook commented 4 years ago

This issue depends on WOTCCommunityhighlander#637.

pledbrook commented 4 years ago

The highlander now has the fix.