long-war-2 / lwotc

Port of Long War 2 to XCOM 2's War of the Chosen expansion
345 stars 91 forks source link

SPARKs can infiltrate more than one mission at once #609

Closed allenhu0912 closed 4 years ago

allenhu0912 commented 5 years ago

Similar to issue 584, a wounded SPARK is always available for infiltration even if he is currently already on a mission

pledbrook commented 5 years ago

Do you have a save for this? I remember this was an issue before, but it was fixed.

allenhu0912 commented 5 years ago

save_Save 90.zip SPARK wounded with 10 hours left, you can send him on multiple missions at once

pledbrook commented 5 years ago

@allenhu0912 Can you confirm that once you remove the SPARK from the squad in Squad Select, you can't add it back?

This appears to be a problem with the Squad Select screen's autofill mechanism, which ignores eStatus_CovertAction for wounded soldiers that can go on missions, i.e. SPARKs.

The solution is probably to fix the bug in the highlander: XComGameState_Unit.CanGoOnMission() should check that the unit's status is not eStatus_CovertAction.

pledbrook commented 4 years ago

Depends on X2WOTCCommunityHighlander#665.

pledbrook commented 4 years ago

Should be fixed in beta 2 with this highlander pull request.