search

long1eu / SpaceTabLayout

Not actively maintained, but PR are welcomed
1.6k stars 265 forks source link

starting_position doesn't seem to work #2

Closed Shailevy closed 7 years ago

Shailevy commented 7 years ago

Iv'e tried the the basic sample code and did: app:starting_position="one"

The starting position was the center anyway. Tried on LG G3 Android 6.0 stock ROM

I also noticed that if I have more than 3 tabs then the text disappears (I'm ignoring the other issue that was already reported with the text overlapping the icon)

Test with version 1.03 and 1.04

long1eu commented 7 years ago

did you tried the new release? 1.0.4?

Shailevy commented 7 years ago

Yes, just now

long1eu commented 7 years ago

O, just a sec and I will give it a look. Thanks for writing :D

long1eu commented 7 years ago

device-2016-12-13-114552 this is what I get at start with this settings :
app:number_of_tabs="three" app:starting_position="one"

Please try again to use the compile 'eu.long1:spacetablayout:1.0.4' in your gradle.build file.

Shailevy commented 7 years ago

I was just about to write you that it worked :) I guess instant-run misses my version change..

Thanks! An other issue: If change the tabs count to five I loose the test .. is this 'As Designed' ?

Shailevy commented 7 years ago

I mean, there is no "text_four" property so it feels on purppose

long1eu commented 7 years ago

ooo, now I understand you

long1eu commented 7 years ago

So I didn't make it to have text above 3 tabs. I think that it is not enough room to proper text. Do you think that it could work?

Shailevy commented 7 years ago

I think it's worth a shot, but if the text and icon won't fit than it's not worth the effort

long1eu commented 7 years ago

I've checked again. There is no proper space for text above 3 tabs. Maybe with a scroll tab that could be possible.

long1eu commented 7 years ago

Thanks again to writing. Have a grate one.