search

long2ice / asynch

An asyncio ClickHouse Python Driver with native (TCP) interface support.
https://github.com/long2ice/asynch
Apache License 2.0
185 stars 43 forks source link

Remove the bare except statement from the Cursor's fetchone method. #118

Closed stankudrow closed 1 month ago

stankudrow commented 1 month ago

Resolves the issue #117 .

stankudrow commented 1 month ago

@llchan, could you possibly review this PR and approve if you like it?

@long2ice , hello, it is up to you whether to merge this PR before the new asynch release or after (relates to the issue #116 ).

Thank you all in advance.

stankudrow commented 1 month ago

@long2ice , @llchan, any suggestions?

llchan commented 1 month ago

LGTM. It may be better to tighten in the future but this at least addresses my concerns about signals getting discarded. I don't think I can approve/merge the PR though so we still need to wait for a maintainer.

stankudrow commented 1 month ago

LGTM. It may be better to tighten in the future but this at least addresses my concerns about signals getting discarded. I don't think I can approve/merge the PR though so we still need to wait for a maintainer.

You have already expressed your support, thank you. Could you share your ideas on tiding and suggestions about future improvements?

stankudrow commented 1 month ago

@llchan , done in the #119 , you can close the issue #118 .