search

long2ice / asynch

An asyncio ClickHouse Python Driver with native (TCP) interface support.
https://github.com/long2ice/asynch
Apache License 2.0
185 stars 43 forks source link

Switch in singular the names for the `Enum`s classes with non-simultaneously-coexisting-values #119

Closed stankudrow closed 1 month ago

stankudrow commented 1 month ago

After some inquiries on enumeration naming guidelines, I realised that it might be a nice idea to have the non bit-field or multiple-flag enumerations singular. the existing enums bear rather mutual exclusive values which cannot be set simultaneously. The rationale -> https://github.com/nats-io/nats.py/pull/619#discussion_r1803671246 .

This PR is important to be considered before the asynch new version release ( the issue #116 ) since it would be easier to handle this now until the enums become a part of public API.

stankudrow commented 1 month ago

@long2ice , need you help, please. This PR also includes the changes from this one ( #118 ), but without messing the CHANGELOG.md file up. Having this PR merged, we can close one issue ( #117 ) and two PRs: this one and, again, #118, which is nice.

long2ice commented 1 month ago

Thanks!

stankudrow commented 1 month ago

@llchan, you can close this issue #118 .