search

long2ice / asynch

An asyncio ClickHouse Python Driver with native (TCP) interface support.
https://github.com/long2ice/asynch
Apache License 2.0
185 stars 43 forks source link

Add (U)?Int(128|256) integer types. #42

Closed palkeo closed 2 years ago

palkeo commented 2 years ago

I had to implement read_items/write_items given that this size of integers is not supported by Python's struct.

Not sure it's ideal to have these new types transitively inherit from FormatColumn, but I wanted to keep the check_items/before_write_items, and this works fine.

long2ice commented 2 years ago

Thanks! Please add unittests about this.

palkeo commented 2 years ago

Done.

randomowo commented 2 years ago

@long2ice when it will be merged?

long2ice commented 2 years ago

Thanks! Looks like ci was failed

long2ice commented 2 years ago

Thanks! Please rebase dev and make ci pass

randomowo commented 2 years ago

i thing using asserts in Big(U)IntColumn is a bad idea if only because if you use python with -O flag asserts would not work.

randomowo commented 2 years ago

@palkeo @long2ice is that okey if i reopen this (and #45) pr from my fork for faster merge?

long2ice commented 2 years ago

@randomowo That's good

randomowo commented 2 years ago

57