long2ice / asynch

An asyncio ClickHouse Python Driver with native (TCP) interface support.
https://github.com/long2ice/asynch
Apache License 2.0
186 stars 43 forks source link

Add connection validity check in acquire method #81

Closed lxneng closed 5 months ago

lxneng commented 1 year ago
itssimon commented 8 months ago

This is a good idea. I'd make it opt-in though.

SQLAlchemy uses the pool_pre_ping argument (default False) to enable this behaviour.

https://docs.sqlalchemy.org/en/20/core/pooling.html#disconnect-handling-pessimistic

long2ice commented 7 months ago

Thanks! Please resolve conflicts first.

lxneng commented 6 months ago

Thanks! Please resolve conflicts first.

@long2ice I have resolved all the conflicts. Please review this PR again. Thank you!

long2ice commented 5 months ago

Thanks!