search

long2ice / asyncmy

A fast asyncio MySQL/MariaDB driver with replication protocol support
https://github.com/long2ice/asyncmy
Apache License 2.0
230 stars 25 forks source link

set echo = True but pool.pyx fill_free_pool create connection without echo parameter #62

Closed happyelements01 closed 1 year ago

happyelements01 commented 1 year ago

Pool init function

https://github.com/long2ice/asyncmy/blob/dev/asyncmy/pool.pyx#LL12C11-L12C11

self._echo not in self._conn_kwargs

Pool fill_free_pool function https://github.com/long2ice/asyncmy/blob/dev/asyncmy/pool.pyx#L124

i set echo is True, but self._echo is not in self._conn_kwargs

when fill_free_pool function create pool connection without echo parameter？

long2ice commented 1 year ago

fixed

happyelements01 commented 1 year ago

fixed

https://github.com/long2ice/asyncmy/issues/62#issuecomment-1548921741

echo without double quotes?

happyelements01 commented 1 year ago

fixed

push the new version to pypi，thanks

happyelements01 commented 1 year ago

fixed

pr

https://github.com/long2ice/asyncmy/pull/63