doesn't play nice with Semantic UI (+ partial solution)

longbill / jquery-date-range-picker

A jQuery plugin that allows user to select a date range

MIT License

1.12k stars 580 forks source link

doesn't play nice with Semantic UI (+ partial solution) #261

Open designosis opened 8 years ago

designosis commented 8 years ago

This is just an FYI for anyone who uses Semantic UI ...

Line 2254 of jquery.daterangepicker.js sets data-tooltip to 'today'tooltip', even if it's blank or hoveringTooltip is set to false. This causes Semantic UI to show a blank tooltip.

By commenting out line 2254, the range picker works great with Semantic UI, despite losing the tooltip.

holtkamp commented 8 years ago

@neokio just a tip when referencing to source code on GitHub. Currently looking into this, but not sure which line you mean, probably this one:

https://github.com/longbill/jquery-date-range-picker/blob/c1f6e42b1cbf88a122c2a499487e31eeed798241/src/jquery.daterangepicker.js#L2475

Can you provide a PR that fixes this? Essentially by first checking wheter data-tooltip has to be set at all...