Fixes an issue where day ranges were being counted incorrectly

longbill / jquery-date-range-picker

A jQuery plugin that allows user to select a date range

MIT License

1.12k stars 578 forks source link

Fixes an issue where day ranges were being counted incorrectly #311

Closed jazanne closed 6 years ago

jazanne commented 7 years ago

Leverages moment.js diff() to count day ranges.

Fixes issue: #310

holtkamp commented 7 years ago

Hey @jazanne sorry, kind of missed your PR 😢 could you perform a rebase to resolve the conflicts?

calebcauthon commented 6 years ago

Nice work!

holtkamp commented 6 years ago

@calebcauthon you seem to be "on" this issue with day counting. https://github.com/longbill/jquery-date-range-picker/pull/379 suggested a similar changes but seem to break some functionality. Do you have the time + knowledge to dive into the use of Moment.js for this?

calebcauthon commented 6 years ago

Haven't gotten around to fully understanding the issue here but here's at least the rebased version of this fix: #423

holtkamp commented 6 years ago

Fixed by https://github.com/longbill/jquery-date-range-picker/pull/423

jazanne commented 6 years ago

thanks for performing the @calebcauthon!