search

longbill / jquery-date-range-picker

A jQuery plugin that allows user to select a date range
MIT License
1.12k stars 579 forks source link

Can we think to seperate translation into self file. #333

Open mazipan opened 7 years ago

mazipan commented 7 years ago

I just think the translation become bigger. I think it's better to create file with each translation. Let say :

It just my thought. If there is an idea, please let me know

mijrs commented 7 years ago

I simply delete the languages i don't use.

holtkamp commented 7 years ago

@mazipan you are right, only thing missing is time to work on this. So a PR would be great...

mazipan commented 7 years ago

yes I do so @mijrs but will be great if we can download from repo with just only language we want

holtkamp commented 7 years ago

@mazipan any suggestion on how to do this? Maybe you can search some other JS projects for "inspiration" 😄 , something like this? http://stackoverflow.com/questions/36253578/how-do-i-change-the-language-to-multiple-files-instead-of-one-in-i18next

Suggestions are welcome

mazipan commented 7 years ago

Sorry ya @holtkamp I have less time to create PR for this issues, but I think the way momentjs (https://github.com/moment/moment/) done with their locale is good enough. They create some locale file with localization, we can choose for any locale and just import to main file.

holtkamp commented 7 years ago

@mazipan ok, thanks for the pointer. For me it is not really a priority to work on this, but maybe on a rainy day 😄

holtkamp commented 7 years ago

@mazipan I had a glance at the i8n approach that https://github.com/moment/moment/ takes, and to be honest, it takes me too long to understand...

holtkamp commented 7 years ago

This seems usable: http://i18njs.com, but introduces an additional dependency 😞

holtkamp commented 7 years ago

@mazipan / others can you guys have a look at: https://github.com/longbill/jquery-date-range-picker/pull/336