Example Config: moment.lang() is deprecated

longbill / jquery-date-range-picker

A jQuery plugin that allows user to select a date range

MIT License

1.12k stars 579 forks source link

Example Config: moment.lang() is deprecated #345

Open jonathanarbely opened 7 years ago

jonathanarbely commented 7 years ago

The default config example contains lang('days') in line 45, which is deprecated since moment v2.8.1 locale(String) should be used from this point on. This causes the tooltip to throw an error in the console and not to work. Should be fixed asap, as this costs devs new to this plugin their time.

holtkamp commented 7 years ago

Hey @jonathanarbely nice catch! A Pull Request is very welcome!

jonathanarbely commented 7 years ago

Hey @holtkamp, I'll try my best to get it done today. 👍 Edit: Will do it asap

holtkamp commented 6 years ago

@jonathanarbely minor bump on this?