Fix days difference in checkSelectionValid()

longbill / jquery-date-range-picker

A jQuery plugin that allows user to select a date range

MIT License

1.12k stars 579 forks source link

Closed niutech closed 6 years ago

niutech commented 6 years ago

In function checkSelectionValid() (jquery.daterangepicker.js:1722) the days difference is counted as follows:

var days = Math.ceil((opt.end - opt.start) / 86400000) + 1;

which does not factor daylight saving time. Instead, it should be:

var days = countDays(opt.end, opt.start);

or using moment.js:

var days = moment(opt.end).diff(moment(opt.start), 'days');

holtkamp commented 6 years ago

Thanks for the report. I also noticed some "strange" behaviour around midnight.

You are referencing to this section:

Would it be an idea to change the (custom) countDays() to using moment.js as well?

niutech commented 6 years ago

Yes, I refer to this line. I think it is a good idea to use moment.js for date diffing, since it it well tested.

holtkamp commented 6 years ago

Ok, a pull-request would be very welcome

niutech commented 6 years ago

Done, but please test it.

holtkamp commented 6 years ago

holtkamp commented 6 years ago