search

longbill / jquery-date-range-picker

A jQuery plugin that allows user to select a date range
MIT License
1.12k stars 579 forks source link

[question] automated testing? #424

Closed calebcauthon closed 6 years ago

calebcauthon commented 6 years ago

Is there a particular reason there is no automated testing? Would it be something that could get merged if it was offered in a PR?

holtkamp commented 6 years ago

Thanks for the questions!

Is there a particular reason there is no automated testing?

Not sure, @longbill started the project, but never added tests. I am not that familiar with JavaScript and only try to maintain the library a bit, since I use it...

Would it be something that could get merged if it was offered in a PR?

Off course! Any decent javascript knowledge is welcome! Also see https://github.com/longbill/jquery-date-range-picker/issues/404

Personally I am thinking of working / playing with TypeScript, it would be nice to have this library adopt this as well. But I simply do not have time for it...

All contributions are welcome!

calebcauthon commented 6 years ago

awesome. thanks!