longhorn / longhorn

Cloud-Native distributed storage built on and for Kubernetes
https://longhorn.io
Apache License 2.0
6.05k stars 595 forks source link

[IMPROVEMENT] Remove the BackupVolume CRD #3375

Open jenting opened 2 years ago

jenting commented 2 years ago

Is your improvement request related to a feature? Please describe

The BackupVolume CRD should be able to remove, all the information that BackupVolume CR required should be able to get from the Backup CRs. This could make the user only need to know how to prepare the Backup CR only without having the knowledge on that BackupVolume CR.

Describe the solution you'd like

Remove the BackupVolume CRD.

Describe alternatives you've considered

None.

Additional context

joshimoo commented 2 years ago

Leaving some notes below,

In the case where we require additional metadata / want to remove the volume.cfg or change the backup.cfg. This is a good time to introduce versioning to the backupstore, see ref: https://github.com/longhorn/longhorn/issues/3175#issuecomment-948774221

Since then the backupstore can be responsible for rendering and returning a newer version DTO based on the old information. While all new backups would be created with the new version.

Reason for versioning:

Other improvements: