Open codepathreview opened 4 years ago
longhuy322000
commented
4 years ago Sorry for the inconvenience. I already implemented these features but forgot to show them in the walkthrough video. I have updated the walkthrough.gif file. Please let me know if you still have any questions.
codepathreview
commented
4 years ago Nice work, LongHuy. It’s great to see how far you’ve come after the first two weeks of the course! This past week we focused a lot on navigation with intents, customizing the App Bar / ToolBar, debugging, and using device SDK’s (like camera and maps). We also got more practice sending network requests and passing parameters to the Twitter API. We hope you found this assignment useful and learned a lot while building your own Twitter app!
We put together a detailed Project 3 Feedback Guide here: http://courses.codepath.org/snippets/android_university_fast_track/feedback_guides/project_3_feedback, which covers the most common issues with this project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Next week we’ll be extending our Twitter Client to learn how to use tabbed navigation and add extra functionality. /cc @codepathreview
majia67
commented
4 years ago Hi Longhuy, congratulations on finishing your second app in the internship! It's great to see you gaining more knowledge on Android development and incorporating previous feedback into your code. Overall you did a fantastic job on building the app and finishing many optional features.
Besides the detailed feedback guide posted by Codepath which I highly recommend you to read, here are a few more concrete feedback on my side:
getViewById. So there is really no need to store the views into separate class members here. Instead, you can get rid of these members and just use the binding to get whatever view you want in the code.
-https://github.com/longhuy322000/FBUSimpleTweet/blob/517c98fe99978bf3bdace1e7888bbb59e95efd20/app/src/main/java/com/codepath/apps/restclienttemplate/activities/TweetDetailsActivity.java#L39-L40
It's better to restrict access level of the class members to its smallest possible scope in order to hide implementation details. I would recommend marking class variables private in most cases.Hope you enjoy the internship so far and looking forward to reviewing your code this week!
codepathreview
commented
4 years ago It looks like your video walkthrough doesn't seem to show some of the required stories as follows:
Also, the stretch feature: User can like a post and see number of likes for each post in the post details screen. The user can only like the post but the number of likes for the post is not seen.
Can you try to update this and resubmit?
/cc @codepathreview
longhuy322000
commented
4 years ago Hi there,
Pull to refresh feature: I show this feature at the end of the first gif in README file (user can pull to refresh the posts) I've added other features in the last gif that I put in README file. Please let me know if I'm still missing something. Sorry for the inconvenience.
Best, LongHuy Nguyen
On Sat, Jul 11, 2020 at 5:58 AM CodePath Reviewers notifications@github.com wrote:
It looks like your video walkthrough doesn't seem to show some of the required stories as follows:
- The current signed in user is persisted across app restarts
- User can pull to refresh the last 20 posts submitted to "Instagram".
Also, the stretch feature: User can like a post and see number of likes for each post in the post details screen. The user can only like the post but the number of likes for the post is not seen.
Can you try to update this and resubmit?
/cc @codepathreview https://github.com/codepathreview
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/longhuy322000/FBUSimpleTweet/issues/1#issuecomment-657030526, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFDESYF4S5RIBCS4HWQTOTR3AZTNANCNFSM4OPZYRHQ .
codepathreview
commented
4 years ago Nice work, LongHuy!
We put together a detailed Project 4 Feedback Guide here: (http://courses.codepath.org/snippets/android_university_fast_track/feedback_guides/project_4_feedback) which covers the most common issues with this project. Read through the feedback guide point-by-point to determine how you could improve your submission.
We hope you enjoyed the course and learned a lot in the process and look forward to see what you build for your final internship project! /cc @codepathreview
It looks like your video walkthrough doesn't seem to show one of the required stories wherein the user can refresh timeline of tweets by pulling down to refresh. Some of the stretch features you listed doesn't seem to show as well as follows: