search

longmeaghan / ml_portfolio

0 stars 0 forks source link

Revert "Converted .html to .php" #25

Closed wellcda closed 6 years ago

wellcda commented 6 years ago

Reverts longmeaghan/ml_portfolio#24.

I wrongfully approved the #24 pull request thinking that you really wanted to change some of the content inside the files, but as I've start working on the project again I've noticed that some old bugs were back and new features were gone.

Check the classes on the image below as an example. image

My guess is that you've created this branch from and old/wrong branch, and not from master.

Please check what's on master right now, and if I'm right accept this pull request, after that we can make the .html files .php again, but from the right branch.

longmeaghan commented 6 years ago

Maybe we should hold off on this merge until everything else on the site gets finalized?

wellcda commented 6 years ago

Ok!