Feature/launch items - Githubissues

longmeaghan / ml_portfolio

0 stars 0 forks source link

Feature/launch items #52

Closed longmeaghan closed 5 years ago

longmeaghan commented 5 years ago

A few issues in this that I tried to fix on my own but no luck.

[x] Tried to add a margine-left: 6px; in .top-info a with no luck. It works in inspector in chrome, but not when I save it in the code
[x] Difficulty with the light gallery for the siggraph.php page

wellcda commented 5 years ago

https://github.com/longmeaghan/ml_portfolio/pull/52/commits/e3597f457c9850009f7720c8faa3dcaa775730bd should fix the checklist above.

On my review I explained why the lightgallery was acting weird; the images were swapped or didn't exist.

About the margin; it may be cache again. Apache may be serving old .css files even when you're cleaning cache? I'm using Nginx and evertyhing is fine.

wellcda commented 5 years ago

I've also optimized every image on commit https://github.com/longmeaghan/ml_portfolio/pull/52/commits/bf9960449610c412dda0eaffcd1989facee1cfec using optipng and jpegoptim.

wellcda commented 5 years ago

Fixes #50 #51 #40 #44 #42 #14