longnguyentan / pe

0 stars 0 forks source link

Issue with `noteCompany` implementation #10

Open longnguyentan opened 11 months ago

longnguyentan commented 11 months ago

If there is no note provided, system should check whether the company already has the note or not

nus-se-bot commented 11 months ago

Team's Response

Thank you for the suggestion! However, we believe that it is not a bug as this is accurate to how our "note" command works and we do not check if the note exists or not!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This answer is for the combination of #4, #5, #10 (related to the noteCompany feature)

I strongly believe that the design of this command, as well as the message, are not well designed, which confuses the users. The noteCompany should check whether there is any note exists or not (together with the valid index) before moving on. This will help to notify the correct output message whether you have removed the intended note of a company or just removed a blank note. And given the data being huge, proper implementation of noteCompany will reduce the risk when working with note data.