search

longshotlabs / meteor-template-extension

A Meteor package: Replace already defined templates, inherit helpers and events from other templates
https://atmospherejs.com/aldeed/template-extension
MIT License
220 stars 20 forks source link

refactor get method to allow geting nested properties #36

Closed pociej closed 7 years ago

mitar commented 9 years ago

Hm, this is not reactive?

pociej commented 9 years ago

not sure if understand you @mitar . Is previous implentation reactive ? How you want to make it reactive if parent property can be everything , in most cases it isnt reactive datasource .

mitar commented 9 years ago

Hm, yea, but why is then this needed? Then there is no much difference between template.get('a.b') and template.get('a').b? Except that you make field names not be able to contain dots?

mitar commented 9 years ago

Oh, I see, because it goes up to the parent if it does not exist. Hmm.

pociej commented 9 years ago

yep its the reason

aldeed commented 9 years ago

@pociej See one comment, but then I think we could merge this. @mitar do you agree?

mitar commented 9 years ago

I think it is OK. But we should document this.

pociej commented 9 years ago

hi @mitar , @aldeed thx for comment will fix today evening .