search

longshotlabs / simpl-schema

A JavaScript schema validation package that supports direct validation of MongoDB update modifier objects
https://www.npmjs.com/package/simpl-schema
MIT License
560 stars 115 forks source link

Tracker is no longer implemented in 3.0.1 #469

Closed thumptech closed 9 months ago

thumptech commented 2 years ago

This means that the error messages will not work when using Autoform on Meteor.

I checked the source code and the reactivity is no longer present.

github-actions[bot] commented 2 years ago

Thank you for submitting an issue!

If this is a bug report, please be sure to include, at minimum, example code showing a small schema and any necessary calls with all their arguments, which will reproduce the issue. Even better, you can link to a saved online code editor example, where anyone can immediately run the code and see the issue.

If you are requesting a feature, include a code example of how you imagine it working if it were implemented.

If you need to edit your issue description, click the [...] and choose Edit.

Be patient. This is a free and freely licensed package that I maintain in my spare time. You may get a response in a day, but it could also take a month. If you benefit from this package and would like to see more of my time devoted to it, you can help by sponsoring.

aldeed commented 2 years ago

This was an intentional change as mentioned in the release notes. Someone is welcome to figure out a solution that does not involve dependency injection, such as an afterValidate hook where you could update a reactive variable, and I will accept a PR for that or help implement if you submit a proposal.

thumptech commented 2 years ago

Thankyou. I didn't even know how the reactivity worked until I looked at the source, unfortunately I don't think I'm skilled enough to come up with a solution, so I'll probably stick to 1.x.x. I imagine this will come up quite a bit in the community so I thought it was worth raising.