longshotlabs / simpl-schema

A JavaScript schema validation package that supports direct validation of MongoDB update modifier objects
https://www.npmjs.com/package/simpl-schema
MIT License
560 stars 114 forks source link

validator({ clean: true }) throws warning #476

Closed jtarvainen closed 6 months ago

jtarvainen commented 1 year ago

The validator function is supposed to accept an optional argument clean:

validator (options: ValidationOptions & { clean?: boolean, returnErrorsPromise?: boolean } ...

But, since version 3.1.0 introduced the "unsupported ... option passed to SimpleSchema clean" warning, I'm getting the warning when I call a ValidatedMethod that has this in its constructor:

validate: schema.validator({ clean: true })

Looking at the validator function definition, it seems that the clean option is unnecessarily passed to clean(). Shouldn't it be left out?

Thanks in advance!

github-actions[bot] commented 1 year ago

Thank you for submitting an issue!

If this is a bug report, please be sure to include, at minimum, example code showing a small schema and any necessary calls with all their arguments, which will reproduce the issue. Even better, you can link to a saved online code editor example, where anyone can immediately run the code and see the issue.

If you are requesting a feature, include a code example of how you imagine it working if it were implemented.

If you need to edit your issue description, click the [...] and choose Edit.

Be patient. This is a free and freely licensed package that I maintain in my spare time. You may get a response in a day, but it could also take a month. If you benefit from this package and would like to see more of my time devoted to it, you can help by sponsoring.

github-actions[bot] commented 6 months ago

:tada: This issue has been resolved in version 3.4.3 :tada:

The release is available on:

If this makes you happy, please consider becoming a sponsor.

Your semantic-release bot :package::rocket: