search

longshotlabs / simpl-schema

A JavaScript schema validation package that supports direct validation of MongoDB update modifier objects
https://www.npmjs.com/package/simpl-schema
MIT License
560 stars 114 forks source link

AutoValue using async functions #484

Open bratelefant opened 1 year ago

bratelefant commented 1 year ago

Hi,

the AutoValueRunner doesn't seem to be able to use async functions. For upcoming changes to Meteor 3.0 this could be crucial imho.

github-actions[bot] commented 1 year ago

Thank you for submitting an issue!

If this is a bug report, please be sure to include, at minimum, example code showing a small schema and any necessary calls with all their arguments, which will reproduce the issue. Even better, you can link to a saved online code editor example, where anyone can immediately run the code and see the issue.

If you are requesting a feature, include a code example of how you imagine it working if it were implemented.

If you need to edit your issue description, click the [...] and choose Edit.

Be patient. This is a free and freely licensed package that I maintain in my spare time. You may get a response in a day, but it could also take a month. If you benefit from this package and would like to see more of my time devoted to it, you can help by sponsoring.

aldeed commented 6 months ago

It's tempting to add async support, but potentially hard or impossible to do without breaking support for form submission validation in browsers, which must be synchronous. In the past I have said that autoValue isn't a good solution when you can't do it synchronously, and I tend to think that's probably still true. If someone wants to attempt a PR that adds a separate autoValueAsync option, I would consider merging it. But I'm not sure it is possible to do this without making the rest of the validation flow async and breaking form submission validation.