Major enhancements to the build tools

longsleep / build-pine64-image

Pine64 Linux build scripts, tools and instructions

MIT License

235 stars 126 forks source link

Major enhancements to the build tools #52

Closed Terra854 closed 7 years ago

Terra854 commented 7 years ago

Added dts for pine64 lcd
build-pine64-image.sh now able to generate different types of images for different configurations
build-pine64-image.sh will attempt to build a simpleimage if none is provided
Generated image size reduced to 1440MB to reduce the time needed to write the image
Generated kernel tarballs now include the pine64 lcd dts and the pinebook dts (developer variant)
Added the ability to generate opensuse images

Signed-off-by: Ben Tinner bentinner@yahoo.com.sg

longsleep commented 7 years ago

Thanks for these changes. Though i am afraid i will not merge them like this. You need to split them up at least into multiple commits so individual changes become visible. Some of the changes are opinionated or do not make much sense to me. If you want me to merge some of this, please split things up into individual merge request, or if you feel this is more like all or nothing then at least into multiple commits. Thanks!

Terra854 commented 7 years ago

Thanks for the tip. I will make the changes

longsleep commented 7 years ago

Do not close pull requests when you plan to update it to avoid loosing previous comments. Simply update/rebase/squash the existing branch and force push. The pull request automatically updates to the HEAD of its branch.

Terra854 commented 7 years ago

You mean i can reverse a commit?