longturn / freeciv21

Develop your civilization from humble roots to a global empire
GNU General Public License v3.0
218 stars 42 forks source link

Add cost to upgrade #1495

Open jwrober opened 1 year ago

jwrober commented 1 year ago

Is your feature request related to a problem? Please describe. There is a standard formula to what it costs to upgrade a unit, however it has to be done by hand outside of the client.

Describe the solution you'd like Do it in the game. Show the cost to upgrade in the unit menu as well as the icon on the control bar. Also ensure that the menu item and the control bar icon is greyed out if not enough gold in the treasury, but active with enough gold.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Came up as part of a question in the newbie-hotline on discord

lmoureaux commented 1 year ago

While showing the cost in the menus would be good, I don't think it solves the mentioned use case (knowing the upgrade cost before upgrading is possible to plan for it). After all, the cost is already shown in the confirmation dialog.

I considered adding the cost to the help dialog, but the effects Upgrade_Price_Pct and Unit_Shield_Value_Pct may change the value (and do in LT*), which is not easy to document.