search

longturn / freeciv21

Develop your civilization from humble roots to a global empire
GNU General Public License v3.0
222 stars 42 forks source link

Improve the units widget when clicking on allied/team cities #1838

Open jwrober opened 1 year ago

jwrober commented 1 year ago

Is your feature request related to a problem? Please describe. In team games or with allies in FFA games, you can click on a allied/team city to see what units are inside. The current widget that pops up makes it really hard to differentiate different types of units and impossible to determine which units are loaded on a particular transport ship. It seems random as to how the units are placed in the widget (I'm sure it's not random, but feels that way).

Also the widget acts like a "menu" and prevents easy screen shots.

Describe the solution you'd like For one, get rid of the menu thing so its easy to get a screen shot for sharing in a team or with an ally.

I would next like to see the widget turned into a QTreeWidget or something so we can organize the units in there better.

  1. Organize by Nation and Unit type, maybe alpha order or at least consistent with how units are organized in the city dialog
  2. Organize by transporter and then add some indicator or arrangement that makes it super easy to determine which unit has been loaded on the ship. Could also follow from #1836
  3. If the units is "mine" and I want to move it to a different ship (also mine or one of my ally/team mates), I should be able to do it from this widget. Maybe via a drag and drop or a right-click menu option.

Describe alternatives you've considered The usual of "leave it alone" comes to mind, but I think we can do better.

Additional context Team games are FUN!

lmoureaux commented 6 months ago

For one, get rid of the menu thing so its easy to get a screen shot for sharing in a team or with an ally.

Wayland solves this, not supporting dying tech like X11 if it takes code.

  1. Organize by Nation and Unit type, maybe alpha order or at least consistent with how units are organized in the city dialog

This is done in #2288.

I don't like the idea of a tree widget as the main UI, because the grid we have is much easier to use when transports are not involved. I could imagine an "expand" button somewhere that would open a more complex dialog for such use cases.

The 3rd item (drag and drop for unit loading) would indeed be cool.