longturn / freeciv21

Develop your civilization from humble roots to a global empire
GNU General Public License v3.0
220 stars 42 forks source link

Modpack installer more like a pkg manager #2136

Open jwrober opened 9 months ago

jwrober commented 9 months ago

Is your feature request related to a problem? Please describe. Right now, the modpack installer is kind of dumb. It simply grabs a list of files to download and does it. The problem is it doesn't handle:

Describe the solution you'd like We already have an open issue for the last bullet (better integration) in #1366. We could add a menu option for it as well in game. Would need to ensure that if a pack is installed in game (and probably off start menu) that a game restart isn't required for the game to see the change.

We have basic dep handling, but you can get cross-wise with circular mapping issues. Not sure we need to handle that per se, but better error messaging/handling would be good. Could be a CI/CD action check at PR open.

We don't do any kind of file list management. Easiest solution is to wipe all files on a re-download and start from scratch. Might be a better scalpel method though. e.g. delete old files and only download changed ones.

We fixed basic reporting in #2133. However might need more SQL changes to handle file level reporting.

Lastly, let's add theme support to the fcmp. Take existing theme the game is set to and display. Creates a more integrated experience. Then we don't have to provide .desktop and metainfo files for the utility.

Right now you need to know the json format and git/github to make submissions. As a nice to have, figure out a way to allow for easier submissions of new content. Maybe follow what flathub does with a repo per package? I'm sure there are other options as well.

Describe alternatives you've considered Discussions have also occurred around using an established package manager. The challenge there is:

Additional context Discord conversation starts here: https://discord.com/channels/378908274113904641/912500712833974322/1192480967407968287

jwrober commented 9 months ago

In reviewing what Battle for Wesnoth has for their modpack installer:

Not that we have to copy them or anything, but some ideas

lmoureaux commented 9 months ago

Ability to install prior/older versions - not sure if this is something we really need

This would be great to have for the LTT/LTX rulesets (one version per game...)