longturn / freeciv21

Develop your civilization from humble roots to a global empire
GNU General Public License v3.0
218 stars 42 forks source link

Citizens of foreign nationality should cause unhappiness even when peace with the original nation #2223

Open wieder-fi opened 6 months ago

wieder-fi commented 6 months ago

Currently it's too easy to give away cities by emptying them, allowing an ally to conquer the cities and then making peace with the conqueror. The current settings allow unhappiness only when there is war between the nations. This could be improved by having a separate unhappiness setting for foreign citizens.

This could be solved by having two separate settings instead of the current one. This is currently controlled with "Enemy_Citizen_Unhappy_Pct" (Royale, LTX) but it only works if the nations are in war with each other. Having another setting allowing to define unhappiness when in peace would allow setups where gifting cities to an ally could still be done but would be less profitable.

Ideally both settings could be used independently of each other.

An example: with democracy x% of people with foreign nationality would be unhappy no matter if the nations in question are in war or if the diplomatic state would be peace. This effect would remain even if the original nation of the foreign citizens would be completely destroyed. On top of that the current effect "Enemy_Citizen_Unhappy_Pct" would result y% of additional unhappiness if the nations would be in war with each other.

lmoureaux commented 6 months ago

Would partisans costing citizens also be (part of) a solution to this?

wieder-fi commented 6 months ago

On Royale ruleset - yes. not sure about LTX. that depends on how the players feel it works there. My guess is that it will be eventually for both but LTX may take some iteration.

hugomflavio commented 6 months ago

Isn't it a better solution for this to let cities be handed over by treaty? Seems more realistic than any other option.

wieder-fi commented 5 months ago

This is not only useful for cases when the city is given with a treaty but for cases where a player allows other player(s) to take the cities with military unit(s). This is not for making it possible or impossible to give cities. Instead this is for making it less profitable to give cities.

lmoureaux commented 2 months ago

I suppose this could be implemented by having Enemy_Citizen_Unhappy_Pct depend on the foreign nationality, enabling DiplRel requirements.