search

longturn / freeciv21

Develop your civilization from humble roots to a global empire
GNU General Public License v3.0
214 stars 39 forks source link

Add "Clean Nuclear Fallout" to "Unit Controls" widget #2274

Closed blabber closed 2 months ago

blabber commented 2 months ago

fallout.svg is based on https://commons.wikimedia.org/wiki/File:Radioactive_White.svg

Closes #2273

blabber commented 2 months ago

Without this PR: missing_fallout

With this PR: fallout_fixed

jwrober commented 2 months ago

@blabber would you pls upload the save game you have w/ fallout?

blabber commented 2 months ago

@blabber would you pls upload the save game you have w/ fallout?

🫴 fallout.sav.xz.zip

jwrober commented 2 months ago

You need to add fill="#000" to the top level <svg open tag for it to work for both light and dark themes. On my local I did this 

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512" fill="#000" ...
blabber commented 2 months ago

You need to add fill="#000" to the top level <svg open tag for it to work for both light and dark themes.

I changed fallout.svg as requested, but to be honest I still don't see any difference in light and dark theme (see screenshots below). Which irritates me even more, is that other icons (for example mine.svg) don't have this fill in their opening <svg ... tag.

Screenshots

Light theme

light

Dark theme

dark

jwrober commented 2 months ago

Thanks for the update and submission of the icon. I am able to reproduce on my local too. I guess something is diff with how we do the unit controls bar vs other UI elements in the game that need that fill code.