longturn / freeciv21

Develop your civilization from humble roots to a global empire
GNU General Public License v3.0
214 stars 39 forks source link

KLocalizedString: Using an empty domain #2294

Closed jwrober closed 1 month ago

jwrober commented 1 month ago

Describe the bug

[warning] freeciv21-client - KLocalizedString: Using an empty domain, fix the code. msgid: "&Yes" msgid_plural: "" msgctxt: "@action:button"
[warning] freeciv21-client - KLocalizedString: Using an empty domain, fix the code. msgid: "&No" msgid_plural: "" msgctxt: "@action:button"
[warning] freeciv21-client - KLocalizedString: Using an empty domain, fix the code. msgid: "&Yes" msgid_plural: "" msgctxt: "@action:button"
[warning] freeciv21-client - KLocalizedString: Using an empty domain, fix the code. msgid: "&No" msgid_plural: "" msgctxt: "@action:button"

To Reproduce Steps to reproduce the behavior:

  1. Start client from command line
  2. See error

Expected behavior No localized string errors

Screenshots N/A

Platform and version (please complete the following information):

Additional context Found while testing PR 2288, but don't think its related. I am running on KDE Neon w/ Qt6, however compiling like normal on Qt5. Don't know if its related, but thought I'd mention it.

lmoureaux commented 1 month ago

Looks like a bug in the latest Kde platform plugin.

lmoureaux commented 1 month ago

KLocalizedString is part of Ki18n, which we do not use. So it's not our bug. More context about this warning in this blog post