Server doesn't always pick best defender to defend

[hugomflavio]

Describe the bug Noticed during the siege of Tracadie (137, 131) on LT83, during T125. In the screenshot below, notice the cannon being called to defend while there are still several cavalries in the city. So much so that the city will actually stand until T126.

To Reproduce It is unclear what causes this.

My best bet to try to reproduce this would be to reload T125 of LT83 from a save, take the Celtiberian nation, and fire the same howitzers in the same order against that city. RNG will make the results be different, but perhaps it will trigger the same odd behaviour nonetheless?

Expected behavior Defenders should be called to defend in order of their best chance to succeed.

Screenshots

Platform and version (please complete the following information):

• OS: Linux
• Freeciv21 version: PR 2312
• Ruleset/Longturn game (if applicable): LTX / LT83

Additional context Louis mentions this had been anecdotally reported before.

[lmoureaux]

I've also seen this but I don't have a way to reproduce. Will try from the save after the game is over.